Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHelp mozjs build where rust-mozjs expects it #1
Conversation
brson
added a commit
that referenced
this pull request
Oct 23, 2012
Help mozjs build where rust-mozjs expects it
|
Thanks! |
kmcallister
pushed a commit
to kmcallister/mozjs
that referenced
this pull request
Oct 24, 2014
Updated a cast in util.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
g2p commentedOct 23, 2012
This versions of mozjs has a js top-level directory that clashes with the ./js binary, at least with the layout rust-mozjs expects when compiling servo. Don't copy the js binary to the wrong place.