Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More portable way to set SHELL to bash. #109

Merged
merged 1 commit into from Dec 22, 2016
Merged

More portable way to set SHELL to bash. #109

merged 1 commit into from Dec 22, 2016
+1 −1

Conversation

@eddyb
Copy link
Contributor

eddyb commented Dec 22, 2016 •
edited by larsbergstrom

This is the only problem I found while trying to build on NixOS (the usual problem from the unpatched virtualenv that SpiderMonkey bundles seems to have fixed itself so 🎉).

This change is Reviewable
@eddyb
More portable way to set SHELL to bash.
Loading status checks…
50b7914
@jdm
Copy link
Member

jdm commented Dec 22, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

📌 Commit 50b7914 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

⌛ Testing commit 50b7914 with merge e975fd8...
bors-servo added a commit that referenced this pull request Dec 22, 2016
@bors-servo
Auto merge of #109 - eddyb:patch-1, r=jdm
Loading status checks…
e975fd8 
More portable way to set SHELL to bash.

This is the only problem I found while trying to build on NixOS (the usual problem from the unpatched virtualenv that SpiderMonkey bundles seems to have fixed itself so 🎉).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/109)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Collaborator

Ms2ger commented Dec 22, 2016

<ted> Ms2ger: FYI it looks like gmake will do a PATH search for you if you just do SHELL := bash
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

📌 Commit 50b7914 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

📌 Commit 50b7914 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

☀️ Test successful - status-appveyor, status-travis
@bors-servo bors-servo merged commit 50b7914 into servo:master Dec 22, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@eddyb eddyb deleted the eddyb:patch-1 branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@eddyb @jdm @bors-servo @Ms2ger
You can’t perform that action at this time.