Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange makefile.cargo to work with Build Tools #111
Merged
Conversation
The Visual C++ Build Tools package (which is freely provided by Microsoft) does not set `VSINSTALLDIR`. On the other hand, `VCINSTALLDIR` should as long as you have Visual C++ in any form. https://social.msdn.microsoft.com/Forums/vstudio/en-US/198f6382-c5d2-4651-9135-0fde236793e7/environment-variables-in-visual-studio?forum=vcgeneral
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 17, 2017
Change makefile.cargo to work with Build Tools The Visual C++ Build Tools package (which is freely provided by Microsoft) does not set `VSINSTALLDIR`. On the other hand, `VCINSTALLDIR` should as long as you have Visual C++ in any form. https://social.msdn.microsoft.com/Forums/vstudio/en-US/198f6382-c5d2-4651-9135-0fde236793e7/environment-variables-in-visual-studio?forum=vcgeneral Everything else is building, so close servo/servo#13325 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/111) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
notriddle commentedJan 17, 2017
•
edited
The Visual C++ Build Tools package (which is freely provided by Microsoft) does not set
VSINSTALLDIR. On the other hand,VCINSTALLDIRshould as long as you have Visual C++ in any form.https://social.msdn.microsoft.com/Forums/vstudio/en-US/198f6382-c5d2-4651-9135-0fde236793e7/environment-variables-in-visual-studio?forum=vcgeneral
Everything else is building, so close servo/servo#13325
This change is