Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MAKEFLAGS to CARGO_MAKEFLAGS for the make command #123

Merged
merged 2 commits into from Oct 17, 2017
Merged

Set MAKEFLAGS to CARGO_MAKEFLAGS for the make command #123

merged 2 commits into from Oct 17, 2017
+13 −3

Conversation

@Eijebong
Copy link
Member

Eijebong commented Oct 16, 2017 •
edited by larsbergstrom

This change is Reviewable
@Eijebong Eijebong mentioned this pull request Oct 16, 2017
Closed
@jdm
Copy link
Member

jdm commented Oct 16, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

📌 Commit 8561605 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

⌛ Testing commit 8561605 with merge b0673dc...
bors-servo added a commit that referenced this pull request Oct 16, 2017
@bors-servo
Auto merge of #123 - Eijebong:makeflags, r=jdm
Loading status checks…
b0673dc 
Set MAKEFLAGS to CARGO_MAKEFLAGS for the make command

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/123)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

💔 Test failed - status-appveyor
@Eijebong
Copy link
Member Author

Eijebong commented Oct 16, 2017

Failure seems unrelated. Looks like some new warning about unused macros isn't happy
@nox
Copy link
Member

nox commented Oct 17, 2017 

make: *** internal error: invalid --jobserver-auth string '__rust_jobserver_semaphore_2744356833'.  Stop.
Eijebong added 2 commits Oct 16, 2017
@Eijebong
Set MAKEFLAGS to CARGO_MAKEFLAGS for the make command
e2d4a2c
@Eijebong
Fix windows build
Loading status checks…
5c90aa4 
Do not set MAKEFLAGS when building for windows as the make used doesn't
support the --jobserver arg
@Eijebong Eijebong force-pushed the Eijebong:makeflags branch from 5ae7493 to 5c90aa4 Oct 17, 2017
@nox
Copy link
Member

nox commented Oct 17, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

📌 Commit 5c90aa4 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

⌛ Testing commit 5c90aa4 with merge 424067c...
bors-servo added a commit that referenced this pull request Oct 17, 2017
@bors-servo
Auto merge of #123 - Eijebong:makeflags, r=nox
Loading status checks…
424067c 
Set MAKEFLAGS to CARGO_MAKEFLAGS for the make command

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/123)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nox
Pushing 424067c to master...
@bors-servo bors-servo merged commit 5c90aa4 into servo:master Oct 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Eijebong @jdm @bors-servo @nox
You can’t perform that action at this time.