Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `exclude` to `Cargo.toml` #128
Merged
Conversation
Excludes tests and documentation, which isn't necessary to build, and therefore not necessary for the .crate tarball.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 2, 2017
Add `exclude` to `Cargo.toml` Excludes tests and documentation, which isn't necessary to build, and therefore not necessary for the .crate tarball. Excluding ICU causes the build to fail. We can investigate this later, if we feel the need. We now have a 50M limit for our crate on crates.io, so we should be able to publish now either way. r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/128) <!-- Reviewable:end -->
|
This brought the .crate tarball down from 35M down to 28M, for the record. |
|
|
|
0.50.0 @ https://crates.io/crates/mozjs_sys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedNov 2, 2017
•
edited by larsbergstrom
Excludes tests and documentation, which isn't necessary to build, and therefore not necessary for the .crate tarball.
Excluding ICU causes the build to fail. We can investigate this later, if we feel the need. We now have a 50M limit for our crate on crates.io, so we should be able to publish now either way.
r? @SimonSapin
This change is