Update SpiderMonkey #130

jdm · 2017-12-18T22:09:15Z

Rebased from #119. Does not incorporate any newer changes from rust-mozjs.

This change is


        Remove old mozjs


        Add new mozjs


        Remove bad Cargo.toml


        Remove testing Cargo.toml files


        WIP Fix finding of the include dir for bindgen

This needs to make its way upstream


        Re-export root through jsapi

This needs to be ported over to the m-c patch queue.


        Add more APIs to work with AutoIdVector.


        Return a ConversionResult::Failure when converting a non-iterable val…

…ue to Vec.


        Wrap uses of extern statics in unsafe blocks.

This fixes safe_extern_statics warnings; see <rust-lang/rust#36247>.


        Improve typed array support.


        Add missing hooks to SIMPLE_GLOBAL_CLASS_OPS.


        Add a test for typed array support.


        Handle panics.


        Fix travis build.


        Fix code involving empty type references

by changing it to use pointers instead. Fixes #311


        Add an implementation of Default for Heap<*mut T>.

We should be able to create a default value for any Heap<*mut T> where *mut T implements GCMethods<*mut T> and Copy, not just for Heap<*mut JSObject>.


        Add a method to create a Heap<T>.

Currently, to create a Heap<T>, one first has to create a Heap<T>::default, and then call Heap<T>::set. This is a common pattern and therefore should be abstracted behind a method.


        Add an implementation of Clone for Heap<T>.


        Add an implementation of PartialEq for Heap<T>.


        Implement a Trace trait for types that can be traced.

We expose several JSAPI functions that are used for tracing. By abstracting these functions behind a trait we can overload them on the type to be traced.


        Use a less strict bound for wrap_panic.

This is what's required for catch_unwind; there's no need to be stricter.


        Implement maybe_wrap_object_value without OOL calls

The only remaining OOL calls are ToWindowIfWindowProxy and JS_WrapValue, like in the equivalent Gecko function.


        Fix a typo in try_to_outerize


        Add methods to create a HandleValueArray.

Rust-mozjs currently does not define any methods to create instances of HandleValueArray. Consequently, consumers have to create these instances manually. This is unnecessary boilerplate, and therefore should be abstracted behind a function.


        Store the JSContext in TLS for easy access.


        Add type for ArrayBufferView.


        Remove the type parameter from GCMethods.

Fixes #256.


        Disallow constructing an unrooted Rooted with a value.

This should make it harder to use Rooted in an unsound way (when not using the rooted!() macro).


        Consistently apply the same bounds to RootedGuard's type parameter.


        Clear the value of a Rooted when the RootedGuard goes out of scope.

This ensures no unrooted values linger in the Rooted when it is no longer rooted. It should be impossible to access the value after that, but Handles currently lack the lifetime to prevent that (#153).


        Factor out the Travis CI test scripts into their own files


        TEMP more debug logging for appveyor stuff


        TEMP don't source tooltool script on windows? sfink says it may work


        TEMP Add logging for whats in C:\Python2.7


        Remove unused import


        Remove unnecessary casts; return Result<(), ()> instead of bool


        TEMP stop using a custom branch of bindgen for logging


        Don't do more than 4 parallel jobs due to travis CI builders OOMing


        Just do 1 make build to avoid OOMs in travis CI


        Ok try 4 parallel jobs because 1 is timing out


        8 parallel jobs because 4 is still timing out


        6 parallel jobs because 8 is OOMing again


        Whitelist JS::Construct


        Whitelist JS_SameValue


        Run autoconf/configure/make inside the mozilla build environment


        Fix bad python 2.7 path on appveyor


        Use -j6 for appveyor builds as well


        WIP building on windows


        Incorporate 33fdb7b.


        Incorporate e2d4a2c.


        Incorporate ce37acf.


        Update bindgen to 0.32.

jdm · 2017-12-18T23:02:25Z

The configure script now complains that GCC needs to be >=4.9.


        Merge before_install blocks.


        Revert "Incorporate e2d4a2c."

This reverts commit ae893a2.


        Try to get more info out the build.


        Force a new build.

atouchet · 2018-08-21T16:37:12Z

Can this be closed now?

fitzgen and others added 30 commits May 10, 2017

Remove old mozjs

ca9fc83

Add new mozjs

14d4579

Remove bad Cargo.toml

a46e351

Remove testing Cargo.toml files

c3a52c1

WIP Fix finding of the include dir for bindgen

4473cb0

This needs to make its way upstream

Re-export root through jsapi

f1eb435

This needs to be ported over to the m-c patch queue.

Add more APIs to work with AutoIdVector.

cafdb83

Return a ConversionResult::Failure when converting a non-iterable val…

f40d7bb

…ue to Vec.

Wrap uses of extern statics in unsafe blocks.

1b5cd60

This fixes safe_extern_statics warnings; see <rust-lang/rust#36247>.

Improve typed array support.

83a2f17

Add missing hooks to SIMPLE_GLOBAL_CLASS_OPS.

5f03a20

Add a test for typed array support.

9c6e2b1

Handle panics.

6e86a39

Fix travis build.

0affd86

Fix code involving empty type references

dda23c8

by changing it to use pointers instead. Fixes #311

Add an implementation of Default for Heap<*mut T>.

1f65c2b

We should be able to create a default value for any Heap<*mut T> where *mut T implements GCMethods<*mut T> and Copy, not just for Heap<*mut JSObject>.

Add a method to create a Heap<T>.

0af7645

Currently, to create a Heap<T>, one first has to create a Heap<T>::default, and then call Heap<T>::set. This is a common pattern and therefore should be abstracted behind a method.

Add an implementation of Clone for Heap<T>.

898fa32

Add an implementation of PartialEq for Heap<T>.

111c4aa

Implement a Trace trait for types that can be traced.

6cf3cdd

We expose several JSAPI functions that are used for tracing. By abstracting these functions behind a trait we can overload them on the type to be traced.

Use a less strict bound for wrap_panic.

f444030

This is what's required for catch_unwind; there's no need to be stricter.

Implement maybe_wrap_object_value without OOL calls

2e4a31c

The only remaining OOL calls are ToWindowIfWindowProxy and JS_WrapValue, like in the equivalent Gecko function.

Fix a typo in try_to_outerize

3ebe671

Add methods to create a HandleValueArray.

5407b0c

Rust-mozjs currently does not define any methods to create instances of HandleValueArray. Consequently, consumers have to create these instances manually. This is unnecessary boilerplate, and therefore should be abstracted behind a function.

Store the JSContext in TLS for easy access.

ea0e757

Add type for ArrayBufferView.

a8e2c7e

Remove the type parameter from GCMethods.

bbb87b7

Fixes #256.

Disallow constructing an unrooted Rooted with a value.

468f6c5

This should make it harder to use Rooted in an unsound way (when not using the rooted!() macro).

Consistently apply the same bounds to RootedGuard's type parameter.

72e8f93

Clear the value of a Rooted when the RootedGuard goes out of scope.

61f56c1

This ensures no unrooted values linger in the Rooted when it is no longer rooted. It should be impossible to access the value after that, but Handles currently lack the lifetime to prevent that (#153).

fitzgen and others added 22 commits Jul 7, 2017

Factor out the Travis CI test scripts into their own files

506147c

TEMP more debug logging for appveyor stuff

40427a2

TEMP don't source tooltool script on windows? sfink says it may work

de37dad

TEMP Add logging for whats in C:\Python2.7

efc901c

Remove unused import

2d26886

Remove unnecessary casts; return Result<(), ()> instead of bool

a1fd9f6

TEMP stop using a custom branch of bindgen for logging

64ee603

Don't do more than 4 parallel jobs due to travis CI builders OOMing

c492a49

Just do 1 make build to avoid OOMs in travis CI

0cad311

Ok try 4 parallel jobs because 1 is timing out

7e6ab3d

8 parallel jobs because 4 is still timing out

46ce7d5

6 parallel jobs because 8 is OOMing again

ef91b67

Whitelist JS::Construct

bfa1824

Whitelist JS_SameValue

9564304

Run autoconf/configure/make inside the mozilla build environment

2ae0bd3

Fix bad python 2.7 path on appveyor

1e16a2f

Use -j6 for appveyor builds as well

6a96388

WIP building on windows

520523d

Incorporate 33fdb7b.

330d225

Incorporate e2d4a2c.

ae893a2

Incorporate ce37acf.

a9366bf

Update bindgen to 0.32.

Loading status checks…

0ab18cf

jdm added 4 commits Dec 19, 2017

Merge before_install blocks.

Loading status checks…

6433ed5

Revert "Incorporate e2d4a2c."

02e9ae7

This reverts commit ae893a2.

Try to get more info out the build.

Loading status checks…

77c3eb4

Force a new build.

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

b32c9cc

emilio mentioned this pull request Mar 7, 2018

for-const-of loop causes syntax error servo/servo#20231

Closed

jdm closed this Aug 21, 2018

servo / mozjs

Update SpiderMonkey #130

Update SpiderMonkey #130

jdm commented Dec 18, 2017 •

edited by larsbergstrom

jdm commented Dec 18, 2017

atouchet commented Aug 21, 2018

servo / mozjs

Join GitHub today

Update SpiderMonkey #130

Update SpiderMonkey #130

Conversation

jdm commented Dec 18, 2017 • edited by larsbergstrom

jdm commented Dec 18, 2017

atouchet commented Aug 21, 2018

jdm commented Dec 18, 2017 •

edited by larsbergstrom