Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to newer Android NDK versions #131
Closed
Conversation
|
This is a bit complicated, since Servo is still using a version prior to r12, and merging this would mean that we couldn't update mozjs until we update. |
|
|
|
|
|
Closing; #138 should support newer android NDKs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ricochet1k commentedJan 12, 2018
•
edited by larsbergstrom
Since r12 I think, the libcxx folder doesn't exist anymore. This lets mozjs_sys build with cargo-apk.
I didn't see any obvious way to predicate on the NDK revision.
This change is