Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #135

Merged
merged 1 commit into from May 23, 2018
Merged

Version bump #135

merged 1 commit into from May 23, 2018

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented May 22, 2018 •
edited by larsbergstrom

This is the version bump for bindgenup, PR #134 which can land once it does.

This change is Reviewable
@asajeffrey
Copy link
Member Author

asajeffrey commented May 22, 2018

r? @jdm
@asajeffrey
Copy link
Member Author

asajeffrey commented May 22, 2018

One annoyance is that according to semver, v0.50.2 is meant to be back-compatible with v0.50.1, which this almost certainly isn't, According to semver this should be v0.51.0, but that conflicts with naming mozjs_sys versions after their SM release number.
@jdm
Copy link
Member

jdm commented May 22, 2018

I don't think it's worth trying to maintain the version number to match the underlying SM version number. It's better to have a realistic semver story.
@asajeffrey
Copy link
Member Author

asajeffrey commented May 22, 2018

OK, v0.51.0 it is!
@jdm
jdm approved these changes May 22, 2018
View changes
@asajeffrey
Version bump
Loading status checks…
762ebb4
@asajeffrey asajeffrey force-pushed the asajeffrey:v0.50.2 branch from a304616 to 762ebb4 May 22, 2018
@asajeffrey asajeffrey changed the title [WIP] Version bump Version bump May 22, 2018
@asajeffrey
Copy link
Member Author

asajeffrey commented May 22, 2018

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2018

📌 Commit 762ebb4 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2018

⌛ Testing commit 762ebb4 with merge 7ea89d9...
bors-servo added a commit that referenced this pull request May 22, 2018
@bors-servo
Auto merge of #135 - asajeffrey:v0.50.2, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7ea89d9 
Version bump

This is the version bump for bindgenup, PR #134 which can land once it does.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/135)
<!-- Reviewable:end -->
@asajeffrey asajeffrey mentioned this pull request May 22, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 7ea89d9 to master...
@bors-servo bors-servo merged commit 762ebb4 into servo:master May 23, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@asajeffrey @jdm @bors-servo
You can’t perform that action at this time.