Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct MOZTOOLS_PATH #145

Merged
merged 1 commit into from Nov 13, 2018
Merged

Correct MOZTOOLS_PATH #145

merged 1 commit into from Nov 13, 2018

Conversation

@mcduke
Copy link
Contributor

mcduke commented Jul 26, 2018 •
edited by larsbergstrom

The proposed MOZTOOLS_PATH no longer seems to be correct, as the current MozillaBuild Package doesn't create either C:\mozilla-build\mozmake or C:\mozilla-build\yasm directories. mozmake.exe and yasm.exe do exist in C:\mozilla-build\bin, though.

This change is Reviewable
@mcduke
Correct MOZTOOLS_PATH
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
be831f0 
The proposed MOZTOOLS_PATH no longer seems to be correct, as the current MozillaBuild Package doesn't create either C:\mozilla-build\mozmake or C:\mozilla-build\yasm directories. mozmake.exe and yasm.exe do exist in C:\mozilla-build\bin, though.
@jdm
jdm approved these changes Jul 26, 2018
View changes
@chrmod chrmod mentioned this pull request Nov 13, 2018
Closed
@chrmod
Copy link

chrmod commented Nov 13, 2018

In my case, python2.7 is missing as well. Adding C:\mozilla-build\python2 to MOZTOOLS_PATH solved the issue
@jdm
Copy link
Member

jdm commented Nov 13, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2018

📌 Commit be831f0 has been approved by jdm
bors-servo added a commit that referenced this pull request Nov 13, 2018
@bors-servo
Auto merge of #145 - mcduke:patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e4d5092 
Correct MOZTOOLS_PATH

The proposed `MOZTOOLS_PATH` no longer seems to be correct, as the current [MozillaBuild Package](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites#MozillaBuild) doesn't create either `C:\mozilla-build\mozmake` or `C:\mozilla-build\yasm` directories. `mozmake.exe` and `yasm.exe` do exist in `C:\mozilla-build\bin`, though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/145)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2018

⌛ Testing commit be831f0 with merge e4d5092...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2018

💔 Test failed - status-travis
@emilio
Copy link
Member

emilio commented Nov 13, 2018

Let's larsbors it since the failure looks like a flake and this is a doc-only update anyway.
@emilio emilio merged commit 180b01c into servo:master Nov 13, 2018
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test failed
Details
code-review/reviewable 1 file left
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mcduke @chrmod @jdm @bors-servo @emilio
You can’t perform that action at this time.