Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate bindgen. #159
Merged
Update bindgen. #159
Conversation
We updated it in Gecko and this is preventing me from syncing stuff with Servo.
|
r? Anyone (@nox / @jdm / @asajeffrey) |
|
@bors-servo r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2018
Update bindgen. We updated it in Gecko and this is preventing me from syncing stuff with Servo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/159) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Oct 28, 2018
style: Sync changes from mozilla-central. See each individual commit. This syncs everything except a bindgen update which is blocked on servo/mozjs#159.
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Oct 28, 2018
style: Sync changes from mozilla-central. See each individual commit. This syncs everything except a bindgen update which is blocked on servo/mozjs#159. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22036) <!-- Reviewable:end -->
|
|
|
Had to add 817b6fb so that now-properly-preserved doc-comments (rust-lang/rust-bindgen#1384) don't get compiled as Rust. Could somebody look at that? Alternative is to disable doc comments I guess. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 29, 2018
Update bindgen. We updated it in Gecko and this is preventing me from syncing stuff with Servo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/159) <!-- Reviewable:end -->
|
|
rust-lang/rust-bindgen#1384 makes bindgen respect whitespace in documentation comments instead of trimming them. This means that some of the comments from the C++ examples try to get compiled as Rust, with a bad result for `cargo test`s purposes. Just test using cargo test --lib. An alternative would be to disable doc comments in bindgen.
|
Whoops, doctests skipped in appveyor as well. @bors-servo r=ajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 29, 2018
Update bindgen. We updated it in Gecko and this is preventing me from syncing stuff with Servo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/159) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2018
Update bindgen. We updated it in Gecko and this is preventing me from syncing stuff with Servo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/159) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedOct 28, 2018
•
edited by larsbergstrom
We updated it in Gecko and this is preventing me from syncing stuff with Servo.
This change is