Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindgen and bump version #164

Merged
merged 2 commits into from Nov 30, 2018
Merged

Update bindgen and bump version #164

merged 2 commits into from Nov 30, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Nov 30, 2018

This change is Reviewable

@jdm
Copy link
Member

jdm commented Nov 30, 2018

There is a new dependency (which) which uses dyn Trait. Rust 1.26 does not like this; let's try upgrading the version of rustc.

@Eijebong
Copy link
Member Author

Eijebong commented Nov 30, 2018

There, updated to 1.27 which should have dyn

@jdm
Copy link
Member

jdm commented Nov 30, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

📌 Commit d2c267f has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

Testing commit d2c267f with merge efc951c...

bors-servo added a commit that referenced this pull request Nov 30, 2018
Update bindgen and bump version

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/164)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing efc951c to master...

@bors-servo bors-servo merged commit d2c267f into servo:master Nov 30, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.