Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix build on clang++ (macOS/freebsd) #168
Closed
Conversation
| @@ -71,6 +71,7 @@ fn cc_flags() -> Vec<&'static str> { | |||
|
|
|||
| if is_apple || is_freebsd { | |||
| result.push("-stdlib=libc++"); | |||
| result.push("-std=c++14"); | |||
This comment has been minimized.
This comment has been minimized.
jbeich
Feb 26, 2019
FWIW, all supported FreeBSD versions ship Clang 6 or later which defaults to C++14 as is.
|
@king6cong Why was this needed? |
|
Closing this, I don't think it is an issue anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
king6cong commentedFeb 26, 2019
•
edited by larsbergstrom
This change is