Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport cross-compiling from x64->x86 on Windows. #176
Conversation
|
r? @Manishearth since Alan's away this week. |
| assert!(env::var("VSINSTALLDIR").is_err()); | ||
| // When cross-compiling on Windows, we need to ensure that the PATH is | ||
| // set up appropriately for the target before invoking make. | ||
| if env::var("VCVARSALL_PATH").is_err() { |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 15, 2019
Support cross-compiling from x64->x86 on Windows. These changes allow building for an x86 target on a x64 host. The changes to the JS glue are an extension of changes we've made in the past for other targets; we have just never run the affected tests for those targets before. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/176) <!-- Reviewable:end -->
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 15, 2019
•
edited by larsbergstrom
These changes allow building for an x86 target on a x64 host. The changes to the JS glue are an extension of changes we've made in the past for other targets; we have just never run the affected tests for those targets before.
This change is