Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-cl to build. #177

Merged
merged 2 commits into from Apr 26, 2019
Merged

Use clang-cl to build. #177

merged 2 commits into from Apr 26, 2019

Conversation

@jdm
Copy link
Member

jdm commented Apr 24, 2019

This will be a hard requirement in forthcoming spidermonkey upgrades, so let's try and switch it on ahead of time.


This change is Reviewable

@jdm
Copy link
Member Author

jdm commented Apr 24, 2019

Let's not merge this until we decide to flip the switch for servo/servo.

@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

Switch flipped.
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

📌 Commit 4eb0b4f has been approved by jdm

bors-servo added a commit that referenced this pull request Apr 26, 2019
Use clang-cl to build.

This will be a hard requirement in forthcoming spidermonkey upgrades, so let's try and switch it on ahead of time.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/177)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

Testing commit 4eb0b4f with merge dde2554...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: jdm
Pushing dde2554 to master...

@bors-servo bors-servo merged commit 4eb0b4f into master Apr 26, 2019
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Branch Build Failed
Details
Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.