Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd _LIBCPP_INLINE_VISIBILITY environment variable #180
Conversation
|
Needed to fix servo/servo#22069 |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 3, 2019
…r=jdm Add _LIBCPP_INLINE_VISIBILITY environment variable This patch allows the `_LIBCPP_INLINE_VISIBILITY` variable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usual `libc++`, such as magicleap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/180) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
May 3, 2019
…r=jdm Add _LIBCPP_INLINE_VISIBILITY environment variable This patch allows the `_LIBCPP_INLINE_VISIBILITY` variable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usual `libc++`, such as magicleap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/180) <!-- Reviewable:end -->
|
|
|
I have retried the individual jobs that failed. |
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
May 3, 2019
…r=jdm Add _LIBCPP_INLINE_VISIBILITY environment variable This patch allows the `_LIBCPP_INLINE_VISIBILITY` variable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usual `libc++`, such as magicleap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/180) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMay 3, 2019
•
edited by larsbergstrom
This patch allows the
_LIBCPP_INLINE_VISIBILITYvariable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usuallibc++, such as magicleap.This change is