Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to SpiderMonkey 67 #186
Merged
+186,759
−189,643
Conversation
|
Windows build doesn't find a viable llvm-config. |
|
Oh joy... https://travis-ci.com/servo/mozjs/jobs/208965905#L2085 |
|
Apart from the travis failure, this all looks sensible. We should edit the git history to make the version bump the last commit. |
|
The travis failure will be fixed by #188. |
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 26, 2019
Upgrade to SpiderMonkey 67 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/186) <!-- Reviewable:end -->
|
|
|
I'm retrying the failed jobs individually. |
|
|
bors-servo
added a commit
to servo/rust-mozjs
that referenced
this pull request
Jun 26, 2019
Upgrade to SpiderMonkey 67 Depends on servo/mozjs#186. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/465) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJun 17, 2019
•
edited by larsbergstrom
This change is