Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CRLF conversion on Windows #187

Merged
merged 1 commit into from Jun 25, 2019
Merged

Prevent CRLF conversion on Windows #187

merged 1 commit into from Jun 25, 2019

Conversation

@saschanaz
Copy link
Contributor

saschanaz commented Jun 24, 2019

As @jdm suggested in servo/servo#23608.


This change is Reviewable

@jdm
Copy link
Member

jdm commented Jun 24, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Jun 24, 2019

📌 Commit 080b423 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jun 24, 2019

Testing commit 080b423 with merge b539bf1...

bors-servo added a commit that referenced this pull request Jun 24, 2019
Prevent CRLF conversion on Windows

As @jdm suggested in servo/servo#23608.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 24, 2019

💔 Test failed - checks-travis

@jdm
Copy link
Member

jdm commented Jun 24, 2019

Need #188 to merge first.

@jdm
Copy link
Member

jdm commented Jun 25, 2019

@bors-servo retry

bors-servo added a commit that referenced this pull request Jun 25, 2019
Prevent CRLF conversion on Windows

As @jdm suggested in servo/servo#23608.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2019

Testing commit 080b423 with merge 4e2062a...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2019

💔 Test failed - checks-travis

@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: jdm
Pushing 4e2062a to master...

@bors-servo bors-servo merged commit 080b423 into servo:master Jun 25, 2019
2 of 3 checks passed
2 of 3 checks passed
Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.