Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWork around Windows arm64 crash #191
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 22, 2019
Work around Windows arm64 crash Running Servo's UWP app on an arm64 device, I encountered crashes creating global options where the app segfaulted when creating RealmOptions values. The crashes disappear when we allocate them on the heap instead of returning them by value. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/191) <!-- Reviewable:end -->
|
|
|
|
bors-servo
added a commit
to servo/rust-mozjs
that referenced
this pull request
Jul 23, 2019
Work around Windows arm64 crashes This creates a nicer API around the RealmOptions changes from servo/mozjs#191. This also works around crashes encountered when passing jsid values by value. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/467) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/rust-mozjs
that referenced
this pull request
Jul 23, 2019
Work around Windows arm64 crashes This creates a nicer API around the RealmOptions changes from servo/mozjs#191. This also works around crashes encountered when passing jsid values by value. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/467) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/rust-mozjs
that referenced
this pull request
Jul 23, 2019
Work around Windows arm64 crashes This creates a nicer API around the RealmOptions changes from servo/mozjs#191. This also works around crashes encountered when passing jsid values by value. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/467) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 22, 2019
•
edited by larsbergstrom
Running Servo's UWP app on an arm64 device, I encountered crashes creating global options where the app segfaulted when creating RealmOptions values. The crashes disappear when we allocate them on the heap instead of returning them by value.
This change is