Force VS 2017 to be used on Windows. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why removing the quotes was necessary, but LGTM. You can r=me. |
|
@bors-servo r=asajeffrey |
|
📌 Commit b405c03 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 26, 2019
Force VS 2017 to be used on Windows. This is important when there are multiple versions of VS installed that the build system might end up trying to use. 2017 is the only supported version for building SpiderMonkey. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/197) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important when there are multiple versions of VS installed that the build system might end up trying to use. 2017 is the only supported version for building SpiderMonkey.
This change is