Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip `cargo:rerun-if-changed` for directories and everything in `.gitignore` (fixes #202) #203

Merged
merged 4 commits into from Sep 30, 2019
Merged

Skip `cargo:rerun-if-changed` for directories and everything in `.gitignore` (fixes #202) #203

merged 4 commits into from Sep 30, 2019
+32 −16

Conversation

@nox
Copy link
Member

nox commented Sep 29, 2019 •
edited by larsbergstrom

The actual fix should live in psutil, but this is a good workaround meanwhile.

This change is Reviewable
@nox
Ignore files and directories named "tmp" (fixes #202)
Loading status checks…
c52c53b 
The actual fix should live in psutil, but this is a good
workaround meanwhile.
@nox nox mentioned this pull request Sep 29, 2019
Closed
SimonSapin added 2 commits Sep 30, 2019
@SimonSapin
Skip `cargo:rerun-if-changed` for everything in `.gitignore`
5cd739d
@SimonSapin
Skip `cargo:rerun-if-changed` for directories
Loading status checks…
16d30e3 
Creating an ignored file changes the mtime of the parent directory
@SimonSapin SimonSapin changed the title Ignore files and directories named "tmp" (fixes #202) Skip `cargo:rerun-if-changed` for directories and everything in `.gitignore` (fixes #202) Sep 30, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Sep 30, 2019

@nox I’ve pushed another couple commits and confirmed that #202 is fixed for me.
@nox
Disable default features of bindgen
Loading status checks…
49474ce 
This removes log, env_logger and clap.
@SimonSapin
Copy link
Member

SimonSapin commented Sep 30, 2019

@bors-servo r=nox+SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

📌 Commit 49474ce has been approved by nox+SimonSapin
bors-servo added a commit that referenced this pull request Sep 30, 2019
@bors-servo
Auto merge of #203 - servo:tmp, r=nox+SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2a6e235 
Skip `cargo:rerun-if-changed` for directories and everything in `.gitignore` (fixes #202)

The actual fix should live in psutil, but this is a good workaround meanwhile.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/203)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

⌛ Testing commit 49474ce with merge 2a6e235...
@nox
Copy link
Member Author

nox commented Sep 30, 2019

@bors-servo r-
@nox
Copy link
Member Author

nox commented Sep 30, 2019

Why ignore directories, actually? Adding new source files or new directories should trigger a rebuild, and AFAIK the only 2 folders that are to be ignored are the two in the psutil folder, which we already take care of.
@nox
Copy link
Member Author

nox commented Sep 30, 2019

10:27 <nox> SimonSapin: Wait no,
10:28 <nox> SimonSapin: we can't ignore directories,
10:28 <nox> what if a new source directory is added?
10:28 <•SimonSapin> won’t some existing files also be modified to reference it?
10:29 <nox> I don't know, but AFAIK we don't need to ignore directories.
10:29 <nox> Was cargo considering your build tree stale if you didn't do that? If so, for which paths?
10:29 <nox> Oh, any path containing a .pyc file…
10:29 <•SimonSapin> I got a spurious failure without this
10:29 <•SimonSapin> s/failure/rebuild/
10:29 <nox> Yeah yeah, let's assume other files will get touched too.

Disregard me.

@bors-servo r=nox,SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

📌 Commit 49474ce has been approved by nox,SimonSapin
bors-servo added a commit that referenced this pull request Sep 30, 2019
@bors-servo
Auto merge of #203 - servo:tmp, r=nox,SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e3ac9b 
Skip `cargo:rerun-if-changed` for directories and everything in `.gitignore` (fixes #202)

The actual fix should live in psutil, but this is a good workaround meanwhile.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/203)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

⌛ Testing commit 49474ce with merge 8e3ac9b...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nox,SimonSapin
Pushing 8e3ac9b to master...
@bors-servo bors-servo merged commit 49474ce into master Sep 30, 2019
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @SimonSapin @bors-servo
You can’t perform that action at this time.