Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport --features vslatestinstalled #205
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2019
Support --features vslatestinstalled Closes #204 This supports opting out `--with-visual-studio-version=2017` by `--features vslatestinstalled`. The name is from the script behavior: https://github.com/servo/mozjs/blob/b2f83932fe9d361face14efd03f2465b9262e687/mozjs/build/moz.configure/toolchain.configure#L650-L652 (My original idea was to do `--with-visual-studio-version=2019` but the option currently only support `2017` as its value.) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/205) <!-- Reviewable:end -->
|
|
|
https://github.com/servo/rust-mozjs/blob/8e99da18185a92a5c10bc7e4bd5249bb9f9c3d84/Cargo.toml#L55 will need to be updated next as well as adding the cargo feature to forward it to this crate. |
bors-servo
added a commit
to servo/rust-mozjs
that referenced
this pull request
Oct 2, 2019
Support `--features vslatestinstalled` Matches servo/mozjs#205 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/477) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
saschanaz commentedOct 1, 2019
•
edited
Closes #204
This supports opting out
--with-visual-studio-version=2017by--features vslatestinstalled.The name is from the script behavior:
mozjs/mozjs/build/moz.configure/toolchain.configure
Lines 650 to 652 in b2f8393
(My original idea was to do
--with-visual-studio-version=2019but the option currently only support2017as its value.)This change is