Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mozjs_sys cope with RLS (fixes #206) #207

Merged
merged 3 commits into from Oct 9, 2019
Merged

Make mozjs_sys cope with RLS (fixes #206) #207

merged 3 commits into from Oct 9, 2019

Conversation

@nox
Copy link
Member

nox commented Oct 7, 2019 •
edited by larsbergstrom

This change is Reviewable
@nox
Copy link
Member Author

nox commented Oct 8, 2019

Oh it did the thing from #169.
nox added 2 commits Oct 7, 2019
@nox
Make mozjs_sys cope with RLS (fixes #206)
5efa196
@nox
Unset MOZCONFIG when running build script (fixes #113)
Loading status checks…
6ba171e
@nox nox force-pushed the rls branch from 0708503 to 6ba171e Oct 8, 2019
@nox
Copy link
Member Author

nox commented Oct 8, 2019

r? @jdm
@nox
Properly inform cargo that we are using some env variables
Loading status checks…
169bcc0
@nox nox force-pushed the rls branch from b96fbbd to 169bcc0 Oct 9, 2019
@jdm
Copy link
Member

jdm commented Oct 9, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

📌 Commit 169bcc0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

⌛ Testing commit 169bcc0 with merge 9e390c4...
bors-servo added a commit that referenced this pull request Oct 9, 2019
@bors-servo
Auto merge of #207 - servo:rls, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e390c4 
Make mozjs_sys cope with RLS (fixes #206)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/207)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: jdm
Pushing 9e390c4 to master...
@bors-servo bors-servo merged commit 169bcc0 into master Oct 9, 2019
5 checks passed
5 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @jdm @bors-servo
You can’t perform that action at this time.