Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more env variables from the build script #208

Closed
wants to merge 1 commit into from
Closed

Handle more env variables from the build script #208

wants to merge 1 commit into from
+21 −4

Conversation

@nox
Copy link
Member

nox commented Oct 10, 2019 •
edited by larsbergstrom

This change is Reviewable
@nox
Handle more env variables from the build script
Loading status checks…
db8288a
@SimonSapin
Copy link
Member

SimonSapin commented Oct 10, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

📌 Commit db8288a has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

⌛ Testing commit db8288a with merge 48babb8...
bors-servo added a commit that referenced this pull request Oct 10, 2019
@bors-servo
Auto merge of #208 - servo:env-vars, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
48babb8 
Handle more env variables from the build script

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/208)
<!-- Reviewable:end -->
@nox
Copy link
Member Author

nox commented Oct 10, 2019

So for some reason, all the tests on the auto branch passed but this didn't land, I'm just going to close it because I have more interesting commits to push.
@nox nox closed this Oct 10, 2019
@nox nox deleted the env-vars branch Oct 10, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

💥 Test timed out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @SimonSapin @bors-servo
You can’t perform that action at this time.