Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy all the sources to OUT_DIR before building them #209

Merged
merged 1 commit into from Oct 11, 2019
Merged

Copy all the sources to OUT_DIR before building them #209

merged 1 commit into from Oct 11, 2019
+119 −64

Conversation

@nox
Copy link
Member

nox commented Oct 10, 2019 •
edited by larsbergstrom

This change is Reviewable
@asajeffrey
Copy link
Member

asajeffrey commented Oct 10, 2019

I'm a bit surprised we need to roll so much code for copying sources, is there not a "recursively copy" off-the-shelf function we can use? Apart from that LGTM, you can r=me.
@nox
Copy link
Member Author

nox commented Oct 10, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

📌 Commit 6cb85a4 has been approved by asajeffrey
bors-servo added a commit that referenced this pull request Oct 10, 2019
@bors-servo
Auto merge of #209 - servo:copy-first, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1fe67f0 
Copy all the sources to OUT_DIR before building them

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/209)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

⌛ Testing commit 6cb85a4 with merge 1fe67f0...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

💔 Test failed - status-appveyor
@nox
Copy all the sources to OUT_DIR before building them
Loading status checks…
1d588b2
@nox nox force-pushed the copy-first branch from 6cb85a4 to 1d588b2 Oct 10, 2019
@nox
Copy link
Member Author

nox commented Oct 10, 2019

@bors-servo r=asajeffrey

This needed some quoting for Windows, should be ok now, hopefully.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

📌 Commit 1d588b2 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2019

⌛ Testing commit 1d588b2 with merge 895dc84...
bors-servo added a commit that referenced this pull request Oct 10, 2019
@bors-servo
Auto merge of #209 - servo:copy-first, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
895dc84 
Copy all the sources to OUT_DIR before building them

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/209)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: asajeffrey
Pushing 895dc84 to master...
@bors-servo bors-servo merged commit 1d588b2 into master Oct 11, 2019
5 checks passed
5 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Jan 6, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @asajeffrey @bors-servo
You can’t perform that action at this time.