Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore outdir build metadata #211

Merged
merged 2 commits into from Oct 11, 2019
Merged

Restore outdir build metadata #211

merged 2 commits into from Oct 11, 2019

Conversation

@nox
Copy link
Member

nox commented Oct 11, 2019

This is accessed by rust-mozjs so it can build its own jsglue.cpp.


This change is Reviewable

@nox nox force-pushed the outdir branch from ca073c3 to b156ab9 Oct 11, 2019
nox added 2 commits Oct 11, 2019
This is accessed by rust-mozjs so it can build its own jsglue.cpp.
@nox nox force-pushed the outdir branch from b156ab9 to 29b28ec Oct 11, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Oct 11, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

📌 Commit 29b28ec has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

Testing commit 29b28ec with merge 618398c...

bors-servo added a commit that referenced this pull request Oct 11, 2019
Restore outdir build metadata

This is accessed by rust-mozjs so it can build its own jsglue.cpp.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/211)
<!-- Reviewable:end -->
@nox
Copy link
Member Author

nox commented Oct 11, 2019

Will you ever land things here, Homu?

@jdm
Copy link
Member

jdm commented Oct 11, 2019

The homu appveyor build started 16 minutes ago.

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: SimonSapin
Pushing 618398c to master...

@bors-servo bors-servo merged commit 29b28ec into master Oct 11, 2019
5 checks passed
5 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.