Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up `config.{guess,sub}` to latest #23

Merged
merged 1 commit into from Jan 6, 2015
Merged

Conversation

@akosthekiss
Copy link
Contributor

akosthekiss commented Jan 6, 2015

Versions from 2009 & 2011 are way too old, latest versions recognize newer architectures as well, e.g., aarch64.

Versions from 2009 & 2011 are way too old, latest versions recognize newer architectures as well, e.g., aarch64.
jdm added a commit that referenced this pull request Jan 6, 2015
Bump up `config.{guess,sub}` to latest
@jdm jdm merged commit 611cdef into servo:master Jan 6, 2015
@akosthekiss akosthekiss deleted the akosthekiss:pr-config-bump branch Jan 6, 2015
@jdm
Copy link
Member

jdm commented Jan 14, 2015

I reverted this change in 39ed76a because I'm pretty sure it broke our android build automation.

@akosthekiss
Copy link
Contributor Author

akosthekiss commented Jan 14, 2015

Can you share any info on what that break was? I wouldn't have expected any side effects from the bump-up.

@jdm
Copy link
Member

jdm commented Jan 15, 2015

This is the failure log from our android builder: http://build.servo.org/builders/android/builds/571/steps/compile/logs/stdio

@akosthekiss
Copy link
Contributor Author

akosthekiss commented Jan 15, 2015

Thanks for the log! Oh my, I think I found it... js/src/configure:1385:1398 (and ultimately, js/src/build/autoconf/android.m4:38:51) seem to be the cause of the problem. And a missing * in the arm-linux*-android* pattern.

Since the newer config.sub returns arm-unknown-linux-androideabi for $target (note that extra -unknown), the pattern above does not match, so $android_tool_prefix will get an incorrect value (that of $target_os, which will miss the arm- cpu part), which in turn will find a bad compiler (somewhere around configure:1757).

If I fix configure and android.m4, may config.{guess,sub} get landed again?

@jdm
Copy link
Member

jdm commented Jan 15, 2015

Yes.

@akosthekiss
Copy link
Contributor Author

akosthekiss commented Jan 15, 2015

new PR (with pattern fixes) here: #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.