Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement for MSVC 2017. #236

Merged
merged 2 commits into from Mar 27, 2020
Merged

Remove the requirement for MSVC 2017. #236

merged 2 commits into from Mar 27, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 19, 2020

This makes it easier to build with MSVC 2019 in the future.

jdm added 2 commits Mar 19, 2020
@jdm
Copy link
Member Author

jdm commented Mar 19, 2020

@Manishearth
Copy link
Member

Manishearth commented Mar 19, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2020

📌 Commit be35174 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2020

Testing commit be35174 with merge 5e013ff...

bors-servo added a commit that referenced this pull request Mar 19, 2020
Remove the requirement for MSVC 2017.

This makes it easier to build with MSVC 2019 in the future.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2020

💔 Test failed - checks-travis

@jdm
Copy link
Member Author

jdm commented Mar 27, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2020

Testing commit be35174 with merge 3e8f3bd...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 3e8f3bd to master...

@bors-servo bors-servo merged commit 3e8f3bd into master Mar 27, 2020
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.