Skip to content

/ mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AArch64 as an architecture supported by Double-Conversion. #24

Merged
merged 1 commit into from Jan 19, 2015
Merged

Add AArch64 as an architecture supported by Double-Conversion. #24

merged 1 commit into from Jan 19, 2015

Conversation

@akosthekiss
Copy link
Contributor

akosthekiss commented Jan 6, 2015

Tested for correctness as described in the comment.
@Ms2ger
Copy link
Collaborator

Ms2ger commented Jan 6, 2015

Would it work to use https://mxr.mozilla.org/mozilla-central/source/mfbt/double-conversion/fix-aarch64-macro.patch instead?
@akosthekiss
Copy link
Contributor Author

akosthekiss commented Jan 6, 2015

If I see it right, the patch would not apply per se, but the idea (using the macro __AARCH64EL__) can be used. However, I'm not sure why support is limited for little endian variants only. (I do have to admint that my box is little endian as well and have no access to a big endian variant, and have no deep knowledge of the code base either -- but after a quick look at the code, I see nothing against EB...)
@akosthekiss akosthekiss force-pushed the akosthekiss:pr-dblconv-aarch64 branch from bd4c757 to bea7f76 Jan 10, 2015
@akosthekiss
Copy link
Contributor Author

akosthekiss commented Jan 15, 2015

So, the question is: shall I try to adapt the above-referenced patch (which is mostly replacing __aarch64__ with __AARCH64EL__ only)?
@jdm
Copy link
Member

jdm commented Jan 15, 2015

Yes, I think I would prefer adapting that patch.
@akosthekiss
Add AArch64 as an architecture supported by Double-Conversion.
808fbeb
@akosthekiss akosthekiss force-pushed the akosthekiss:pr-dblconv-aarch64 branch from bea7f76 to 808fbeb Jan 15, 2015
@akosthekiss
Copy link
Contributor Author

akosthekiss commented Jan 17, 2015

What do you think about the adapted patch?
jdm added a commit that referenced this pull request Jan 19, 2015
@jdm
Merge pull request #24 from akiss77/pr-dblconv-aarch64
58ee886 
Add AArch64 as an architecture supported by Double-Conversion.
@jdm jdm merged commit 58ee886 into servo:master Jan 19, 2015
@akosthekiss akosthekiss deleted the akosthekiss:pr-dblconv-aarch64 branch Jan 19, 2015
asajeffrey pushed a commit to asajeffrey/mozjs that referenced this pull request Dec 21, 2017
@fitzgen
Merge pull request servo#24 from asajeffrey/fitzgen-smup-smup-smup
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9982c34 
Getting smup to work with josephine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@akosthekiss @Ms2ger @jdm
You can’t perform that action at this time.