Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew python2 fix #241

Merged
merged 2 commits into from Mar 31, 2020
Merged

Homebrew python2 fix #241

merged 2 commits into from Mar 31, 2020

Conversation

@sagudev
Copy link
Contributor

sagudev commented Mar 30, 2020

@jdm
Copy link
Member

jdm commented Mar 30, 2020

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

📌 Commit b34dd70 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

Testing commit b34dd70 with merge 4acc98d...

bors-servo added a commit that referenced this pull request Mar 30, 2020
Homebrew python2 fix

Same as servo/rust-mozjs#500
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

💔 Test failed - checks-travis

@jdm
Copy link
Member

jdm commented Mar 30, 2020

I wonder if this is the difference between the xcode10.2 image and the xcode11 image that rust-mozjs uses?

@jdm
Copy link
Member

jdm commented Mar 31, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

📌 Commit a032a11 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

Testing commit a032a11 with merge 8429d3f...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: jdm
Pushing 8429d3f to master...

@bors-servo bors-servo merged commit 8429d3f into servo:master Mar 31, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@sagudev sagudev deleted the sagudev:patch-1 branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.