Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump up `config.{guess,sub}` to latest and fix the Android-on-ARM pattern in `configure` and in `android.m4 #26
Conversation
…tern in `configure` and in `android.m4
Versions of `config.{guess,sub}` from 2009 & 2011 are way too old, latest versions
recognize newer architectures as well, e.g., aarch64, so a bump-up is timely. However,
a pattern used in `configure` (originating from `android.m4`) is too restrictive:
`arm-linux*-android*` does not match the `arm-unknown-linux-androideabi` string
returned by recent `config.sub`, so it needs fixing.
Bump up `config.{guess,sub}` to latest and fix the Android-on-ARM pattern in `configure` and in `android.m4
|
Please also submit a pull request to servo/servo that makes use of this too, so we avoid the problem we had last time and this gets tested immediately :) |
|
Is that really servo/servo (where I cannot find anything similar), or should it be https://mxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4 ? (If the latter, I'll have to find out how to propose a patch there.) |
|
What I mean is that the servo repository is locked to particular revisions of dependencies (like mozjs) via the Cargo.lock file. You can update these revisions using |
As requested in servo/mozjs#26
|
FYI: contributed the |
|
Thanks! |
…:pr-update-mozjs); r=jdm As requested in servo/mozjs#26 Source-Repo: https://github.com/servo/servo Source-Revision: 772570d06b8a75f376cfb50b334de7dbaa5c0382
…:pr-update-mozjs); r=jdm As requested in servo/mozjs#26 Source-Repo: https://github.com/servo/servo Source-Revision: 772570d06b8a75f376cfb50b334de7dbaa5c0382 UltraBlame original commit: f29ec68909e85ea7c9090df660b6f93b099ab1a2
…:pr-update-mozjs); r=jdm As requested in servo/mozjs#26 Source-Repo: https://github.com/servo/servo Source-Revision: 772570d06b8a75f376cfb50b334de7dbaa5c0382 UltraBlame original commit: f29ec68909e85ea7c9090df660b6f93b099ab1a2
…:pr-update-mozjs); r=jdm As requested in servo/mozjs#26 Source-Repo: https://github.com/servo/servo Source-Revision: 772570d06b8a75f376cfb50b334de7dbaa5c0382 UltraBlame original commit: f29ec68909e85ea7c9090df660b6f93b099ab1a2
akosthekiss commentedJan 15, 2015
Versions of
config.{guess,sub}from 2009 & 2011 are way too old, latest versionsrecognize newer architectures as well, e.g., aarch64, so a bump-up is timely. However,
a pattern used in
configure(originating fromandroid.m4) is too restrictive:arm-linux*-android*does not match thearm-unknown-linux-androideabistringreturned by recent
config.sub, so it needs fixing.