Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRustup 2015 01 31 #28
Merged
+41
−2
Conversation
This patch fixes three issues on Windows:
- Set `$(CC)` properly and pass it to `js/src/configure`.
- Set dummy `$(MOZ_TOOLS)` since `configure` requires non-empty
value.
- Fix `$(OUT_DIR)` due to incompatibility between cargo (which uses
Windows native path e.g. `C:\path`) and msys make (which uses
`/c/path`).
With such modifications, it succeeded to build on Windows.
(Tested with: rustc 134e00be7 2015-02-09, cargo 9404539 2015-02-09)
Fix Windows build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedFeb 11, 2015
No description provided.