Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBackport the patch for bug 784631 #3
Merged
+6
−5
Conversation
metajack
added a commit
that referenced
this pull request
Apr 29, 2013
Backport the patch for bug 784631
kmcallister
pushed a commit
to kmcallister/mozjs
that referenced
this pull request
Oct 24, 2014
Fix build errors: use extern keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sethfowler commentedApr 29, 2013
Without this change, we get a build failure when using recent clang: