Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to Spidermonkey 39 #34
Closed
+3,768,353
−1,056,432
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michaelwu commentedApr 24, 2015
Well, not really spidermonkey 39. It's just whatever I had pulled from master at the time. Maybe mozilla/gecko-dev@2f60231 ?
All the imported code goes into the mozjs directory now. There's a linker hack to disable some weak linking in MFBT which doesn't work with the way servo links things together. I'll probably have to discuss that with glandium. There's also a hack to remove PR_GetCurrentThread since that's totally broken if you're not using NSPR. That just needs to be cleaned up a bit and landed upstream.
I'm not entirely sure what to do with the library naming. I would actually prefer if we didn't use a shared mozjs on Android.