Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBackport memory reporting changes from bug 1181452 #49
Conversation
This was referenced Jul 8, 2015
This comment has been minimized.
This comment has been minimized.
michaelwu
commented on mozjs/js/public/MemoryMetrics.h in fe0ffa5
Jul 8, 2015
|
Our bindings generator can bind to most c++ classes as long as you're not using templates. (and if you use templates, you can use them if you only use them for types) |
|
Travis wasn't turned off, but I have now fixed that. Bors will be able to integrate this patch when it's reviewed. |
|
This is fine with me. Just waiting on the code to land on mozilla-central. |
|
I just landed the SpiderMonkey patches to mozilla-inbound: https://bugzilla.mozilla.org/show_bug.cgi?id=1181452#c5 |
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 14, 2015
Backport memory reporting changes from bug 1181452 The code is being backported from https://bugzilla.mozilla.org/show_bug.cgi?id=1181452. This change shouldn't land until the one in the Bugzilla bug has landed.
|
|
bors-servo
pushed a commit
to servo/rust-mozjs
that referenced
this pull request
Jul 14, 2015
Add glue to use SpiderMonkey's memory reporting from Rust code. This cannot land until servo/mozjs#49 has landed. And it must land before servo/servo#6572 can land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nnethercote commentedJul 8, 2015
The code is being backported from https://bugzilla.mozilla.org/show_bug.cgi?id=1181452. This change shouldn't land until the one in the Bugzilla bug has landed.