Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix debug build #5
Merged
+11
−3
Conversation
Should cut down compile time a little bit.
SpiderMonkey defines 'jsid' to be a struct type in debug builds, which changes the mangled names of some functions, producing a linker error. This feature serves only to catch mistakes in the SpiderMonkey C++ code, so for Servo we just disable it.
This comment has been minimized.
This comment has been minimized.
metajack
commented on bac8c7f
Sep 4, 2013
|
Good idea! |
This comment has been minimized.
This comment has been minimized.
metajack
commented on js/src/Makefile.in in 5aef769
Sep 4, 2013
|
This seems odd. What kind of linker error? Should this be a FIXME? |
This comment has been minimized.
This comment has been minimized.
|
Consider js::BaseProxyHandler::hasOwn(JSContext*, JSObject*, jsid id, bool*)In a release build, js::BaseProxyHandler::hasOwn(JSContext*, JSObject*, long, bool*)In a debug build it's a struct and the name mentions Presumably there's a way to make the |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 5aef769
Sep 4, 2013
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kmcallister commentedSep 4, 2013
I tried to do this within Servo's
mk/config.mkbutCFLAGS_mozjsthere seems to have no effect.