Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate SM headers to reflect the headers used in bindings generation #55
Conversation
| @@ -29,8 +29,10 @@ enum TransferableOwnership { | |||
| // Structured clone buffer does not yet own the data | |||
| SCTAG_TMO_UNOWNED = 1, | |||
|
|
|||
| #ifndef RUST_BINDGEN | |||
This comment has been minimized.
This comment has been minimized.
tschneidereit
Sep 25, 2015
It'd be good to have comments on stuff like this. We can do that during upstreaming, though.
This comment has been minimized.
This comment has been minimized.
tschneidereit
commented on mozjs/js/src/jsapi.h in cbc562d
Sep 25, 2015
|
What's the issue with using aliases in enums? It seems like bindgen converts those just fine. |
This comment has been minimized.
This comment has been minimized.
|
It converts enums to consts, not enums. bindgen++ actually tries to convert them to Rust enums. |
This comment has been minimized.
This comment has been minimized.
tschneidereit
replied
Sep 25, 2015
|
Oh, of course. I wasn't able to build your clang fork so didn't check what bindgen++ does. |
|
r? @jdm |
|
I think this is useful as a reference, but we don't have to merge it. It should be obsolete at some point since we want to upstream it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michaelwu commentedSep 24, 2015
This isn't necessary to use the new bindings, but allow people other than myself to generate the bindings.
CC @tschneidereit