Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdates to make mozjs work with newer SM versions #56
+51
−16,365
Conversation
… when first used as a PRThread in the PosixNSPR implementation
Newer SpiderMonkey versions don't link it in dist/lib.
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Oct 1, 2015
Add a dependency on autoconf-2.13 This is necessary for servo/mozjs#56 which runs autoconf at build time instead of checking in configure. No idea if this will work on osx.. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/122) <!-- Reviewable:end -->
|
@tschneidereit Does this still need more work? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tschneidereit commentedOct 1, 2015
Not quite ready to land, but close.