Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of bug 1224722 - Enable executing multiple embedding-provided inputs as self-hosted JS during runtime startup #65

Closed
wants to merge 1 commit into from

Conversation

@tschneidereit
Copy link

tschneidereit commented Nov 24, 2015

@michaelwu wanted to use this in his self-hosting experiments.

Review on Reviewable

…d inputs as self-hosted JS during runtime startup
@Ms2ger
Copy link
Collaborator

Ms2ger commented Nov 24, 2015

We should just do a full update, except nobody seems to want to do that or explain how to do it.

@tschneidereit
Copy link
Author

tschneidereit commented Nov 24, 2015

We should just do a full update, except nobody seems to want to do that or explain how to do it.

I agree in principle. However, applying the hacks that make the current mozjs work for Servo on top of current mozilla-central is non-trivial, and won't ever get easier, really. Hence, I'd like to instead get rid of as many of these hacks as possible, partly by working around the need for them, partly by upstreaming proper fixes. I started looking into this a few weeks back, and it seems feasible. In fact, it's one of my Q4 goals to get to a point where we can use pristine upstream and do away with mozjs in its current form entirely. (Whether I can manage to actually get to that point this quarter remains to be seen. I did lose a few weeks because of that stupid accident.)

For the time being, backporting this patch took about 10 minutes, so seemed to be well-worth it.

@michaelwu
Copy link
Contributor

michaelwu commented Nov 26, 2015

I'm getting an assertion at MOZ_ASSERT(hasContexts()); in JSRuntime::evaluateSelfHosted. Should it be the opposite?

@michaelwu
Copy link
Contributor

michaelwu commented Nov 26, 2015

MOZ_ASSERT(selfHostingGlobal_); is also failing. Guess I'm probably doing something wrong..

@michaelwu
Copy link
Contributor

michaelwu commented Nov 26, 2015

Ok, seems to work.

@Ms2ger Ms2ger closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.