Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBackport of bug 1224722 - Enable executing multiple embedding-provided inputs as self-hosted JS during runtime startup #65
Conversation
…d inputs as self-hosted JS during runtime startup
|
We should just do a full update, except nobody seems to want to do that or explain how to do it. |
I agree in principle. However, applying the hacks that make the current mozjs work for Servo on top of current mozilla-central is non-trivial, and won't ever get easier, really. Hence, I'd like to instead get rid of as many of these hacks as possible, partly by working around the need for them, partly by upstreaming proper fixes. I started looking into this a few weeks back, and it seems feasible. In fact, it's one of my Q4 goals to get to a point where we can use pristine upstream and do away with mozjs in its current form entirely. (Whether I can manage to actually get to that point this quarter remains to be seen. I did lose a few weeks because of that stupid accident.) For the time being, backporting this patch took about 10 minutes, so seemed to be well-worth it. |
|
I'm getting an assertion at MOZ_ASSERT(hasContexts()); in JSRuntime::evaluateSelfHosted. Should it be the opposite? |
|
MOZ_ASSERT(selfHostingGlobal_); is also failing. Guess I'm probably doing something wrong.. |
|
Ok, seems to work. |
tschneidereit commentedNov 24, 2015
@michaelwu wanted to use this in his self-hosting experiments.