Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[do not merge] smup #93
Closed
+84,719
−25,536
Conversation
…SpiderMonkey.patch
|
r? @Ms2ger |
This was fixed in upstream bug 1284824 and bug 1286207.
fitzgen
changed the title
fitzgen
force-pushed the
fitzgen:remove-upstreamed-patch
branch
from
687aea6
to
377002b
|
Ok with these 9 commits, all patches re-apply cleanly and |
|
This all seems fine, but I think I want to keep the patches in sync with the commit we're actually on. |
Because we also hide the unions related to these assertions.
These things are not the same between 32 and 64 bits.
We need to use that type in constant context.
Need it in constant context.
…ose visibillity attributes
|
I guess I can do a full smup then... will need help on windows and linux 32. |
fitzgen
changed the title
|
Create a PR with your progress on rust-mozjs, will ping people to help with those platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedAug 18, 2016
•
edited
Fixes #92
This change is