Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpand upgrading instructions some more #95
Merged
Conversation
* Mention building servo's bindgen fork * Describe running `rust-mozjs/etc/bindings.sh` in more detail
| Generate the non-`DEBUG` bindings: | ||
|
|
||
| ``` | ||
| $ cargo build |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks! It's great to have someone look at those instructions with fresh eyes. @bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2016
…s2ger Expand upgrading instructions some more * Mention building servo's bindgen fork * Describe running `rust-mozjs/etc/bindings.sh` in more detail r? @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/95) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedAug 22, 2016
•
edited by larsbergstrom
rust-mozjs/etc/bindings.shin more detailr? @Ms2ger
This change is