Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline tags are chars not i8s #108

Merged
merged 1 commit into from Mar 6, 2019
Merged

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Mar 6, 2019

In font-renderer/src/freetype/outline.rs there's an assumption that c_char is i8, so it fails to compile on architectures where c_char is u8:

info: component 'rust-std' for target 'aarch64-linux-android' is up to date
   Compiling pathfinder_font_renderer v0.5.0 (/Users/ajeffrey/github/asajeffrey/pathfinder/font-renderer)
   Compiling script_layout_interface v0.0.1 (/Users/ajeffrey/github/asajeffrey/servo/components/script_layout_interface)
   Compiling layout_traits v0.0.1 (/Users/ajeffrey/github/asajeffrey/servo/components/layout_traits)
error[E0308]: mismatched types
  --> /Users/ajeffrey/github/asajeffrey/pathfinder/font-renderer/src/freetype/outline.rs:65:24
   |
65 |             (position, tag)
   |                        ^^^ expected i8, found u8

error: aborting due to previous error
@pcwalton pcwalton merged commit 3a33e5e into servo:webrender Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.