Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Transform3DF32::from_quaternion #111
Closed
Conversation
|
Needs SIMD |
|
Why does this need SIMD but, e.g, |
|
The code will be clearer with SIMD. Give me a few minutes and I'll make a go of it. |
|
(I'd also prefer to use rotors instead of quaternions, but I'm OK with deferring that.) |
pcwalton
added a commit
that referenced
this pull request
Mar 20, 2019
pcwalton
added a commit
that referenced
this pull request
Mar 20, 2019
|
I pushed this patch, partially SIMD-ified: pcwalton@26fea26 (It's untested but I triple checked it.) Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMar 20, 2019
Add a function to build a transform from a quaternion.