Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a non-zero default framebuffer #113

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Mar 20, 2019

Allows using pathfinder when the default framebuffer is non-zero (e.g. on ML1).

gl/src/lib.rs Outdated Show resolved Hide resolved
@@ -27,12 +27,20 @@ use std::time::Duration;

pub struct GLDevice {
version: GLVersion,
default_framebuffer_id: GLuint,

This comment has been minimized.

@pcwalton

pcwalton Mar 21, 2019

Collaborator

uber-nit: "object" is the preferred GL terminology over "id"

This comment has been minimized.

@asajeffrey

asajeffrey Mar 21, 2019

Author Member

I renamed to default_framebuffer.

@asajeffrey asajeffrey force-pushed the asajeffrey:gl-nonzero-default-framebuffer branch from 585e2d9 to ab3b28f Mar 21, 2019
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Mar 21, 2019
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Mar 25, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Mar 25, 2019

@pcwalton review ping?

@pcwalton pcwalton merged commit 29cedb9 into servo:pf3 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.