Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow devices to set transforms for each camera #114
Merged
Conversation
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 20, 2019
asajeffrey
changed the title
asajeffrey
force-pushed the
asajeffrey:demo-camera-transforms-event
branch
from
5c98523
to
a8b42b8
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 20, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 21, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 21, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 21, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 25, 2019
asajeffrey
force-pushed the
asajeffrey:demo-camera-transforms-event
branch
from
a8b42b8
to
dd7e4ee
|
Rebased. |
asajeffrey
force-pushed the
asajeffrey:demo-camera-transforms-event
branch
from
dd7e4ee
to
e60dff1
|
Rebased. @pcwalton review ping? |
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Apr 8, 2019
asajeffrey
force-pushed the
asajeffrey:demo-camera-transforms-event
branch
from
e60dff1
to
b5771f2
|
Rebased. |
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Apr 10, 2019
demo/common/src/lib.rs
Outdated
| ThreeD { transform: CameraTransform3D, velocity: Point3DF32 }, | ||
| ThreeD { | ||
| // The mode will either be 3D or VR | ||
| mode: Mode, |
This comment has been minimized.
This comment has been minimized.
pcwalton
Apr 10, 2019
Collaborator
This seems redundant; the mode can be detected by looking at the length of transforms. How about making this a method (e.g. is_stereo()) on Camera?
This comment has been minimized.
This comment has been minimized.
asajeffrey
Apr 12, 2019
Author
Member
Fixed. I kept the mode() method, rather than going for is_stereo(), just because that fits the way the method is used.
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Apr 11, 2019
asajeffrey
force-pushed the
asajeffrey:demo-camera-transforms-event
branch
from
eb57b13
to
5c30913
|
Rebased. |
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Apr 12, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Apr 12, 2019
|
Merged in 3996d9a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMar 20, 2019
Allow the device to set different camera transforms for each eye.