Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upA couple of features for Options #117
Merged
+95
−44
Conversation
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 21, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 22, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 22, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 25, 2019
|
Rebased. |
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 26, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 26, 2019
|
Review ping? |
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 28, 2019
asajeffrey
added a commit
to asajeffrey/pathfinder
that referenced
this pull request
Mar 28, 2019
|
I think it'd be good to allow making the UI invisible while the app is running, not just as a command line switch. Maybe allow the Tab key to cycle through "full UI", "only debug window", "no UI" options, and then add a command line switch to start in one of those modes. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMar 21, 2019
A couple of changes to option-handling: