Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black background, and a bg option #118

Closed
wants to merge 2 commits into from

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Mar 22, 2019

Allows a black background.

asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Mar 22, 2019
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Mar 22, 2019
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Mar 25, 2019
@asajeffrey asajeffrey force-pushed the asajeffrey:pf3-background branch from 658fe0b to 2c1ad40 Mar 26, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Mar 26, 2019

Rebased.

@pcwalton
Copy link
Collaborator

pcwalton commented Apr 2, 2019

I was giving this some thought, and I was thinking what might work best is to change the "sun/moon" option slider into a popup that brings up a menu with "Light", "Dark", and "Transparent" options. Transparent would be what AR uses. This would also give us a transparent window on desktop, which could be a cool demo in its own right. What do you think?

@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 2, 2019

Fine by me.

@pcwalton
Copy link
Collaborator

pcwalton commented Apr 2, 2019

This looks good once conflicts are resolved.

@asajeffrey asajeffrey force-pushed the asajeffrey:pf3-background branch from 2c1ad40 to ce48bbd Apr 2, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 2, 2019

A couple of thoughts...

If we have a transparent background, what should the native demo display? Black?

How about we put off the replacement of the buttons with a menu for a different PR?

@pcwalton
Copy link
Collaborator

pcwalton commented Apr 2, 2019

If we have a transparent background, what should the native demo display? Black?

Well, ideally it would ask SDL to recreate the window in transparent mode. (We don't want to have SDL always create a transparent window because that will slow all rendering down in the opaque case by 4ms or more.)

That may be a bit of work, though. Black is OK for now (though honestly we shouldn't even display the "transparent" option in that case).

How about we put off the replacement of the buttons with a menu for a different PR?

That's OK.

@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 8, 2019

@pcwalton Care to press the big green merge button?

@asajeffrey asajeffrey force-pushed the asajeffrey:pf3-background branch from ce48bbd to 42fec47 Apr 8, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 8, 2019

Rebased.

asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Apr 9, 2019
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Apr 9, 2019
@asajeffrey asajeffrey force-pushed the asajeffrey:pf3-background branch from 42fec47 to 52dc824 Apr 10, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 10, 2019

Rebased.

asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Apr 10, 2019
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Apr 10, 2019
@pcwalton
Copy link
Collaborator

pcwalton commented Apr 10, 2019

Commit c5ccd0f implements this.

@pcwalton pcwalton closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.