Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd black background, and a bg option #118
Conversation
|
Rebased. |
|
I was giving this some thought, and I was thinking what might work best is to change the "sun/moon" option slider into a popup that brings up a menu with "Light", "Dark", and "Transparent" options. Transparent would be what AR uses. This would also give us a transparent window on desktop, which could be a cool demo in its own right. What do you think? |
|
Fine by me. |
|
This looks good once conflicts are resolved. |
|
A couple of thoughts... If we have a transparent background, what should the How about we put off the replacement of the buttons with a menu for a different PR? |
Well, ideally it would ask SDL to recreate the window in transparent mode. (We don't want to have SDL always create a transparent window because that will slow all rendering down in the opaque case by 4ms or more.) That may be a bit of work, though. Black is OK for now (though honestly we shouldn't even display the "transparent" option in that case).
That's OK. |
|
@pcwalton Care to press the big green merge button? |
|
Rebased. |
|
Rebased. |
|
Commit c5ccd0f implements this. |
asajeffrey commentedMar 22, 2019
Allows a black background.