Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made BackgroundColor public #129

Closed
wants to merge 1 commit into from
Closed

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Apr 11, 2019

Trying to use BackgroundColor outside pathfinder_demo results in:

error[E0603]: enum `BackgroundColor` is private
  --> demo/magicleap/src/lib.rs:28:22
   |
28 | use pathfinder_demo::BackgroundColor;
   |                      ^^^^^^^^^^^^^^^

or

error[E0603]: module `ui` is private
  --> demo/magicleap/src/lib.rs:28:22
   |
28 | use pathfinder_demo::ui::BackgroundColor;
   |                      ^^
asajeffrey added a commit to asajeffrey/pathfinder that referenced this pull request Apr 11, 2019
@pcwalton
Copy link
Collaborator

pcwalton commented Apr 12, 2019

I have an informal policy of no pub use, because I think it makes crates harder to understand. I landed this without it in 782e352.

@pcwalton pcwalton closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.