Skip to content

/ pathfinder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence unused variable warning #152

Closed
wants to merge 1 commit into from
Closed

Silence unused variable warning #152

wants to merge 1 commit into from

Conversation

@luisbg
Copy link
Contributor

luisbg commented May 16, 2019

Silencing the following rustc warning:
warning: unused variable: other

Small fix but I want to contribute more if you are OK with it 😄
@luisbg
Silence unused variable warning
3129f6c 
Silencing the following rustc warning:
warning: unused variable: `other`
@pcwalton
Copy link
Collaborator

pcwalton commented May 21, 2019

I think we should just remove the cross method entirely.
@luisbg
Copy link
Contributor Author

luisbg commented May 22, 2019 •
edited

Sounds good. I can remove the cross method in a different follow up PR soon.

I will close this one.

Thanks for the review.
@luisbg luisbg closed this May 22, 2019
luisbg added a commit to luisbg/pathfinder that referenced this pull request May 24, 2019
@luisbg
Remove cross method from F32x4
8c0415c 
Silencing the following rustc warning:
warning: unused variable: `other`

Followup to Pull Request servo#152.
Instead of marking `other` unused (`_other`) we can remove the method
entirely.
@luisbg luisbg mentioned this pull request May 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@luisbg @pcwalton
You can’t perform that action at this time.