Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStart adding tests for scalar::F32x4 #173
Merged
Conversation
simd/src/test.rs
Outdated
| @@ -9,6 +9,7 @@ | |||
| // except according to those terms. | |||
|
|
|||
| use crate::default::{F32x4, I32x4, U32x4}; | |||
| use crate::scalar::F32x4 as sF32x4; | |||
This comment has been minimized.
This comment has been minimized.
pcwalton
May 29, 2019
Collaborator
nit: Rust conventions want capital letters for type names. How about F32x4S?
|
Updated. I forgot to say this raises the coverage to 21.37%. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luisbg commentedMay 29, 2019
This isn't complete but I wanted to check with you that the structure is OK.