Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get magicleap working again #175

Merged
merged 6 commits into from Jun 3, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jun 3, 2019

These are the changes needed to get the magicleap demo running again. There are some minor changes to the common demo, the main one is calling make_current for each eye during rendering, previously we were assuming the only difference between eyes was the viewport.

@jdm
Copy link
Member

jdm commented Jun 3, 2019

error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/lib.rs:32:33
   |
32 | use pathfinder_geometry::basic::point::Point2DF;
   |                                 ^^^^^ could not find `point` in `basic`
error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/lib.rs:33:33
   |
33 | use pathfinder_geometry::basic::point::Point2DI;
   |                                 ^^^^^ could not find `point` in `basic`
error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/magicleap.rs:51:33
   |
51 | use pathfinder_geometry::basic::point::Point2DI;
   |                                 ^^^^^ could not find `point` in `basic`
error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/magicleap.rs:52:33
   |
52 | use pathfinder_geometry::basic::point::Point2DF;
   |                                 ^^^^^ could not find `point` in `basic`
error: aborting due to 4 previous errors
For more information about this error, try `rustc --explain E0432`.
error: Could not compile `pathfinder_magicleap_demo`.
To learn more, run the command again with --verbose.
The command "cargo build" exited with 101.
@pcwalton
Copy link
Collaborator

pcwalton commented Jun 3, 2019

Looks good. I just removed cross, so the first commit can be removed.

@asajeffrey asajeffrey force-pushed the asajeffrey:get-magicleap-working-again branch from cc17ffa to c71a208 Jun 3, 2019
@pcwalton
Copy link
Collaborator

pcwalton commented Jun 3, 2019

@asajeffrey Point has been renamed to Vector. You can run something like sed s/::point/::vector/g and s/\bPoint(\d)D/Vector\1/g.

@pcwalton pcwalton merged commit 5e64ee4 into servo:master Jun 3, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.