Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet magicleap working again #175
Merged
Conversation
|
|
Looks good. I just removed |
cc17ffa
to
c71a208
|
@asajeffrey Point has been renamed to Vector. You can run something like sed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJun 3, 2019
These are the changes needed to get the magicleap demo running again. There are some minor changes to the common demo, the main one is calling
make_currentfor each eye during rendering, previously we were assuming the only difference between eyes was the viewport.