Skip to content

Comments

Get magicleap working again#175

Merged
pcwalton merged 6 commits intoservo:masterfrom
asajeffrey:get-magicleap-working-again
Jun 3, 2019
Merged

Get magicleap working again#175
pcwalton merged 6 commits intoservo:masterfrom
asajeffrey:get-magicleap-working-again

Conversation

@asajeffrey
Copy link

These are the changes needed to get the magicleap demo running again. There are some minor changes to the common demo, the main one is calling make_current for each eye during rendering, previously we were assuming the only difference between eyes was the viewport.

@jdm
Copy link
Member

jdm commented Jun 3, 2019

error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/lib.rs:32:33
   |
32 | use pathfinder_geometry::basic::point::Point2DF;
   |                                 ^^^^^ could not find `point` in `basic`
error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/lib.rs:33:33
   |
33 | use pathfinder_geometry::basic::point::Point2DI;
   |                                 ^^^^^ could not find `point` in `basic`
error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/magicleap.rs:51:33
   |
51 | use pathfinder_geometry::basic::point::Point2DI;
   |                                 ^^^^^ could not find `point` in `basic`
error[E0432]: unresolved import `pathfinder_geometry::basic::point`
  --> demo/magicleap/src/magicleap.rs:52:33
   |
52 | use pathfinder_geometry::basic::point::Point2DF;
   |                                 ^^^^^ could not find `point` in `basic`
error: aborting due to 4 previous errors
For more information about this error, try `rustc --explain E0432`.
error: Could not compile `pathfinder_magicleap_demo`.
To learn more, run the command again with --verbose.
The command "cargo build" exited with 101.

@pcwalton
Copy link
Contributor

pcwalton commented Jun 3, 2019

Looks good. I just removed cross, so the first commit can be removed.

@asajeffrey asajeffrey force-pushed the get-magicleap-working-again branch from cc17ffa to c71a208 Compare June 3, 2019 22:52
@pcwalton
Copy link
Contributor

pcwalton commented Jun 3, 2019

@asajeffrey Point has been renamed to Vector. You can run something like sed s/::point/::vector/g and s/\bPoint(\d)D/Vector\1/g.

@pcwalton pcwalton merged commit 5e64ee4 into servo:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants